-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erlang/OTP 21 logger integration #7649
Conversation
Could we get the optimisations to |
9d51f2a
to
9d6b0b5
Compare
9d6b0b5
to
bd5b1b1
Compare
This is ready for review. I just need to write tests for the new handler and it is ready to go. |
@@ -70,7 +70,7 @@ defmodule ExUnit.CaptureLog do | |||
{:ok, string_io} = StringIO.open("") | |||
|
|||
try do | |||
_ = :gen_event.which_handlers(:error_logger) | |||
_ = Process.whereis(:error_logger) && :gen_event.which_handlers(:error_logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for info: there's a new error_logger:which_report_handlers()
- which returns the empty list if error_logger
process is not running. But can of course only be used if you know you're running on 21.
defp erlang_level_to_elixir_level(:critical), do: :error | ||
defp erlang_level_to_elixir_level(:error), do: :error | ||
defp erlang_level_to_elixir_level(:warning), do: :warn | ||
defp erlang_level_to_elixir_level(:info), do: :info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing notice
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sirihansen Thanks! I am glad you noticed that.
❤️ 💚 💙 💛 💜 |
I have merged this because it causes some intermittent failures in our suite, making it really hard to work on other Erlang/OTP 21 features. Please drop any other feedback in this thread and I will get to it. :) |
Just one minor doc-thing - logger.ex, line 574 - should probably remove "both":
|
@sirihansen thanks! |
No description provided.