Reenable tasks without side-effects, that only run code #7855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fertapric
reviewed
Jul 10, 2018
| ## Command-line options | ||
|
|
||
| * `--config`, `-c` - loads the given configuration file | ||
| * `--eval`, `-e` - evaluates the given code | ||
| * `--require`, `-r` - requires pattern before running the command | ||
| * `--require`, `-r` - executes the given pattern/file |
There was a problem hiding this comment.
I wonder if this change is consistent with the description of the next flag:
parallel,-p- makes all requires parallel
Maybe “requires (and executes) the given pattern/file”?
There was a problem hiding this comment.
I think so, since the word "requires" is talking about the --require flag. Thoughts?
ericmj
approved these changes
Jul 11, 2018
|
I think this is a sensible change, I don't see any downsides to this. |
michalmuskala
approved these changes
Jul 11, 2018
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7848.