Accordingly mark top level optional dependencies from child deps #8035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be backported and we should release v1.7.2. |
ericmj
reviewed
Aug 3, 2018
lib/mix/lib/mix/dep.ex
Outdated
| # is still available means it has been fulfilled. | ||
| opts = | ||
| dep.opts | ||
| |> Keyword.drop(@child_keep_opts) |
There was a problem hiding this comment.
Is it correct to explicitly drop? I don't think we should remove the :runtime option unless it exist at a higher level for example.
There was a problem hiding this comment.
Yes, whatever is given upstream should be ignored. That's because we assume an implicit default of true. So even if downstream specifies false, the dependency still wants it to be true (because it requires it!)
There was a problem hiding this comment.
I have pushed a new test to emphasize why the drop matters!
lib/mix/lib/mix/dep.ex
Outdated
| %{^app => child_opts} -> | ||
| # Only top level dependencies can be optional. | ||
| # Any non-top level dependency that is optional and | ||
| # is still available means it has been fulfilled. |
There was a problem hiding this comment.
The comment needs to be updated regarding :runtime.
| Mix.Tasks.Deps.Compile.run([]) | ||
| end) | ||
| end) | ||
| end |
michalmuskala
approved these changes
Aug 4, 2018
|
❤️ 💚 💙 💛 💜 |
josevalim
added a commit
that referenced
this pull request
Aug 4, 2018
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7990