[WIP] mix release support #8677
Conversation
|
Hi everyone, this PR is feature complete for the goals it aims to achieve (for a complete roadmap see #8612). The missing parts are:
This means it would be really appreciated if we start to get some reviews in. There are two ways you can help:
Thanks! |
Co-Authored-By: josevalim <jose.valim@gmail.com>
Co-Authored-By: josevalim <jose.valim@gmail.com>
Co-Authored-By: josevalim <jose.valim@gmail.com>
|
Integration tests are in. It is just a matter of becoming green on Travis+Appveyor. |
|
@josevalim Are you planning one merging this soon, or in the near future? I'm asking this because I'm started working on converting the bin scripts to a POSIX compliant, but I worked master. I see many of the non-POSIX compliant code have been eliminated in this PR. |
|
@eksperimental I want to merge it really soon. Regarding POSIX, CI got a bunch of failures, that's why they have been fixed. :) But I would appreciate if the new PR is based off this branch. |
|
Right on. I will submit a PR once this gets merged. |
|
@eksperimental tests are green on travis, which means we should no longer change the script files. :) |
|
@eksperimental btw, if you can also review the release scripts for POSIX standards, it would be awesome. Although we should be good on this front too. |
|
OK, I will do that then. |
|
❤️ 💚 💙 💛 💜 |
| @@ -186,14 +206,18 @@ else | |||
| if [ $USE_WERL ]; then ERL_EXEC="werl"; fi | |||
| fi | |||
|
|
|||
| set -- "$ERTS_BIN$ERL_EXEC" -pa "$SCRIPT_PATH"/../lib/*/ebin $ELIXIR_ERL_OPTIONS $ERL -extra "$@" | |||
| ERTS_BIN="" | |||
There was a problem hiding this comment.
ERTS_BIN is not doing anything in this script, as it will always be ""
|
It is replaced when we assemble the release.
--
*José Valimwww.plataformatec.com.br
<http://www.plataformatec.com.br/>Founder and Director of R&D*
|
For the complete roadmap for releases, see #8612.