Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] mix release support #8677

Merged
merged 55 commits into from Jan 28, 2019

Conversation

@josevalim
Copy link
Member

commented Jan 22, 2019

For the complete roadmap for releases, see #8612.

@josevalim josevalim referenced this pull request Jan 22, 2019

Closed

Releases #8612

6 of 6 tasks complete
@josevalim

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2019

Hi everyone, this PR is feature complete for the goals it aims to achieve (for a complete roadmap see #8612). The missing parts are:

  • Windows tooling
  • Improve the test suite

This means it would be really appreciated if we start to get some reviews in. There are two ways you can help:

  1. Review the code in the PR
  2. Review the docs. The docs are all here: https://github.com/elixir-lang/elixir/pull/8677/files#diff-53c844525c23fd1a21c03113baf7e781R3

Thanks!

Update lib/mix/lib/mix/release.ex
Co-Authored-By: josevalim <jose.valim@gmail.com>

lukaszsamson and others added some commits Jan 24, 2019

Apply suggestions from code review
Co-Authored-By: josevalim <jose.valim@gmail.com>
Update lib/mix/lib/mix/tasks/release.ex
Co-Authored-By: josevalim <jose.valim@gmail.com>

josevalim added some commits Jan 24, 2019

josevalim added some commits Jan 28, 2019

@josevalim

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2019

Integration tests are in. It is just a matter of becoming green on Travis+Appveyor.

@eksperimental

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

@josevalim Are you planning one merging this soon, or in the near future? I'm asking this because I'm started working on converting the bin scripts to a POSIX compliant, but I worked master. I see many of the non-POSIX compliant code have been eliminated in this PR.
So far I have only worked on bin/elixir but it's looking good.

@josevalim

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2019

@eksperimental I want to merge it really soon. Regarding POSIX, CI got a bunch of failures, that's why they have been fixed. :) But I would appreciate if the new PR is based off this branch.

@eksperimental

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

Right on. I will submit a PR once this gets merged.

@josevalim

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2019

@eksperimental tests are green on travis, which means we should no longer change the script files. :)

@josevalim

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2019

@eksperimental btw, if you can also review the release scripts for POSIX standards, it would be awesome. Although we should be good on this front too.

josevalim added some commits Jan 28, 2019

@eksperimental

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

OK, I will do that then.

@josevalim josevalim merged commit dc03037 into master Jan 28, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@josevalim

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2019

❤️ 💚 💙 💛 💜

@josevalim josevalim deleted the jv-basic-releases branch Jan 28, 2019

@@ -186,14 +206,18 @@ else
if [ $USE_WERL ]; then ERL_EXEC="werl"; fi
fi

set -- "$ERTS_BIN$ERL_EXEC" -pa "$SCRIPT_PATH"/../lib/*/ebin $ELIXIR_ERL_OPTIONS $ERL -extra "$@"
ERTS_BIN=""

This comment has been minimized.

Copy link
@eksperimental

eksperimental Jan 29, 2019

Member

ERTS_BIN is not doing anything in this script, as it will always be ""

@josevalim

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.