Skip to content

CI feature: Reproducible build #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 28, 2019
Merged

CI feature: Reproducible build #8701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ce1bab4
Add Reproducible Build feature to CI
eksperimental Jan 25, 2019
0083ab6
Move commands after tests
eksperimental Jan 25, 2019
67c4d42
Run "make compile" after without .git dir
eksperimental Jan 25, 2019
3674ce7
do not delete files in ebin_reproducible
eksperimental Jan 25, 2019
f3fb8a3
Only execute reproducible build in lastest OTP release
eksperimental Jan 25, 2019
7cc1620
run tests in the future
eksperimental Jan 25, 2019
2769755
Revert changes related to Run tests in the Future
eksperimental Jan 25, 2019
acd1d70
Run "make clean" before second "make compile"
eksperimental Jan 25, 2019
db810db
Move to Makefile
eksperimental Jan 26, 2019
da635ac
fix
eksperimental Jan 26, 2019
86c19d0
export SOURCE_DATE_EPOCH in Makefile to see if it works in Travis
eksperimental Jan 26, 2019
170f76c
fix over fix
eksperimental Jan 26, 2019
ac632a3
implement Jose's suggestions
eksperimental Jan 26, 2019
63d8bb5
don't clean files at the very end
eksperimental Jan 26, 2019
9b43b0e
Update Makefile
josevalim Jan 26, 2019
19d75df
Update Makefile
josevalim Jan 26, 2019
d29239f
Makefile: implement (read/write)_SOURCE_DATE_EPOCH
eksperimental Jan 26, 2019
befe9cc
Add back all OTP releases to .travis.yml
eksperimental Jan 26, 2019
8361c43
Use uppercase in Mafile function names
eksperimental Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
- OTP_RELEASE=OTP-20.3
- OTP_RELEASE=OTP-21.0
- OTP_RELEASE=OTP-21.1
- OTP_RELEASE=OTP-21.2
- OTP_RELEASE=OTP-21.2 CHECK_REPRODUCIBLE=true
- OTP_RELEASE=maint
- OTP_RELEASE=master

Expand All @@ -29,11 +29,14 @@ install:
- PATH=$(pwd)/otp/bin:$PATH

script:
- ELIXIRC_OPTS="--warnings-as-errors" ERLC_OPTS="+warning_as_errors" make compile
- rm -rf .git
- ELIXIRC_OPTS="--warnings-as-errors" ERLC_OPTS="+warning_as_errors" make compile
- make test
- dialyzer -pa lib/elixir/ebin --build_plt --output_plt elixir.plt --apps lib/elixir/ebin/elixir.beam lib/elixir/ebin/Elixir.Kernel.beam

# Check for reproducible builds only in the latest OTP release
- if [ -n "$CHECK_REPRODUCIBLE" ]; then make check_reproducible; fi

notifications:
recipients:
- jose.valim@gmail.com
Expand Down
39 changes: 38 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ INSTALL_DATA = $(INSTALL) -m644
INSTALL_PROGRAM = $(INSTALL) -m755
GIT_REVISION = $(strip $(shell git rev-parse HEAD 2> /dev/null ))
GIT_TAG = $(strip $(shell head="$(call GIT_REVISION)"; git tag --points-at $$head 2> /dev/null | tail -1) )
SOURCE_DATE_EPOCH_PATH = lib/elixir/tmp/ebin_reproducible
SOURCE_DATE_EPOCH_FILE = $(SOURCE_DATE_EPOCH_PATH)/SOURCE_DATE_EPOCH

.PHONY: install compile erlang elixir unicode app build_plt clean_plt dialyze test clean clean_residual_files install_man clean_man docs Docs.zip Precompiled.zip zips
.PHONY: install compile erlang elixir unicode app build_plt clean_plt dialyze test check_reproducible clean clean_residual_files install_man clean_man docs Docs.zip Precompiled.zip zips
.NOTPARALLEL: compile

#==> Functions
Expand Down Expand Up @@ -46,6 +48,18 @@ test_$(1): compile $(1)
$(Q) cd lib/$(1) && ../../bin/elixir -r "test/test_helper.exs" -pr "test/**/*_test.exs";
endef

define WRITE_SOURCE_DATE_EPOCH
$(shell mkdir -p $(SOURCE_DATE_EPOCH_PATH) && bin/elixir -e \
'IO.puts System.build_info()[:date] \
|> DateTime.from_iso8601() \
|> elem(1) \
|> DateTime.to_unix()' > $(SOURCE_DATE_EPOCH_FILE))
endef

define READ_SOURCE_DATE_EPOCH
$(strip $(shell cat $(SOURCE_DATE_EPOCH_FILE)))
endef

#==> Compilation tasks

APP := lib/elixir/ebin/elixir.app
Expand Down Expand Up @@ -113,6 +127,29 @@ install: compile
done
$(MAKE) install_man

check_reproducible: compile
$(Q) echo "==> Checking for reproducible builds..."
$(Q) rm -rf lib/*/tmp/ebin_reproducible/
$(call WRITE_SOURCE_DATE_EPOCH)
$(Q) mkdir -p lib/elixir/tmp/ebin_reproducible/ \
lib/eex/tmp/ebin_reproducible/ \
lib/iex/tmp/ebin_reproducible/ \
lib/logger/tmp/ebin_reproducible/ \
lib/mix/tmp/ebin_reproducible/
$(Q) mv lib/elixir/ebin/* lib/elixir/tmp/ebin_reproducible/
$(Q) mv lib/eex/ebin/* lib/eex/tmp/ebin_reproducible/
$(Q) mv lib/iex/ebin/* lib/iex/tmp/ebin_reproducible/
$(Q) mv lib/logger/ebin/* lib/logger/tmp/ebin_reproducible/
$(Q) mv lib/mix/ebin/* lib/mix/tmp/ebin_reproducible/
SOURCE_DATE_EPOCH=$(call READ_SOURCE_DATE_EPOCH) $(MAKE) compile
$(Q) echo "Diffing..."
$(Q) diff -r lib/elixir/ebin/ lib/elixir/tmp/ebin_reproducible/
$(Q) diff -r lib/eex/ebin/ lib/eex/tmp/ebin_reproducible/
$(Q) diff -r lib/iex/ebin/ lib/iex/tmp/ebin_reproducible/
$(Q) diff -r lib/logger/ebin/ lib/logger/tmp/ebin_reproducible/
$(Q) diff -r lib/mix/ebin/ lib/mix/tmp/ebin_reproducible/
$(Q) echo "Builds are reproducible"

clean:
rm -rf ebin
rm -rf lib/*/ebin
Expand Down