No longer generate config for mix new #8932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact we explicitly told developers to configure their
application in the config file and access it with
Application.get_env/2
, probably led many to rely onthe application environment when better options are
available.
Furthermore,
mix new
is mostly used for libraries,where config is even less important, as configuration
from libraries is not transitive.
Developers that need the config, can simply add it back
by calling:
This commit removes config for new apps and deprecate
the
--config
flag, which cannot perform deep merges.Note we do keep the config for umbrellas, as umbrellas
are about applications and not libraries (plus we need
the umbrella children to share and point to an existing
config).
Closes #8815.
Closes #8811.