Mention custom scripts in mix release "One-off commands" docs #9105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
commented
Jun 1, 2019
lib/mix/lib/mix/tasks/release.ex
Outdated
| bin/RELEASE_NAME eval "MyApp.ReleaseTasks.migrate_db()" | ||
| bin/RELEASE_NAME rpc "MyApp.ReleaseTasks.print_connected_users()" | ||
|
|
||
| Finally, you may still automate this further by creating standalone scripts |
There was a problem hiding this comment.
The section below has probably way too much code so maybe it's better to show the functions but let users fill in the blanks, or skip this thing altogether?
There was a problem hiding this comment.
Yeah, we should probably keep this focused. I have pushed some updates, let me know what you think.
|
@josevalim looks good! |
josevalim
approved these changes
Jun 1, 2019
|
Thanks @wojtekmach! 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most projects will end up with some kind of
MyApp.ReleaseTasksmodule so I think we could mention it in the docs.