Skip to content

Clarify syntax for custom Module attributes #9109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2019
Merged

Clarify syntax for custom Module attributes #9109

merged 2 commits into from
Jun 3, 2019

Conversation

fertapric
Copy link
Member

Related to #9084

@fertapric fertapric changed the title Clarify syntax of custom Module attributes Clarify syntax for custom Module attributes Jun 3, 2019
whatyouhide
whatyouhide reviewed Jun 3, 2019
View reviewed changes
fertapric
fertapric commented Jun 3, 2019
View reviewed changes
@fertapric fertapric merged commit 462dc57 into master Jun 3, 2019
@fertapric fertapric deleted the fertapric-clarify-mod-attr branch June 3, 2019 10:59
@fertapric fertapric mentioned this pull request Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatyouhide whatyouhide whatyouhide left review comments

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fertapric @josevalim @whatyouhide