Skip to content

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Apr 11, 2013

... records

@josevalim
Copy link
Member

/cc @orenbenkiki

This implements the feature we discussed on the mailing list. You can work with a defrecord as if it was a defrecordp.

@yrashk
Copy link
Contributor Author

yrashk commented Apr 11, 2013

@orenbenkiki is this what you were looking for? If yes, we're merging this.

@orenbenkiki
Copy link

I thought the idea was to make defrecord and defrecordp behave exactly the same, except the question of whether everything was private or public. At least, Jose said in one of his messages that he believed this is what we should aim for - and it does seem reasonable...

If the goal is just to allow defrecordp-like macros when using defrecord, then this would work.

@yrashk
Copy link
Contributor Author

yrashk commented Apr 12, 2013

@josevalim ?

@josevalim
Copy link
Member

Unfortunately we can't make them behave the same. All we can do is to allow them to work through a similar API, like this. @yrashk I am merging this, but would you mind updating the defrecord docs later to mention about this feature?

josevalim pushed a commit that referenced this pull request Apr 12, 2013
Implement Record.import macro that allows using private macros on public...
@josevalim josevalim merged commit ec69bdf into elixir-lang:master Apr 12, 2013
@yrashk
Copy link
Contributor Author

yrashk commented Apr 12, 2013

Will do

On Thu, Apr 11, 2013 at 10:09 PM, José Valim notifications@github.comwrote:

Unfortunately we can't make them behave the same. All we can do is to
allow them to work through a similar API, like this. @yrashkhttps://github.com/yrashkI am merging this, but would you mind updating the
defrecord docs later to mention about this feature?


Reply to this email directly or view it on GitHubhttps://github.com//pull/945#issuecomment-16276196
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants