Make index redirect warning case-sensitive #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
reviewed
Aug 8, 2019
josevalim
reviewed
Aug 8, 2019
cybrox
force-pushed
the
case-sensitive-main
branch
from
161cf58
to
60ce2dd
Compare
lib/ex_doc/formatter/html.ex
Outdated
| defp case_sensitive_file_regular?(path) do | ||
| if File.regular?(path) do | ||
| files = path |> Path.dirname() |> File.ls!() | ||
| file = path |> Path.basename() |
There was a problem hiding this comment.
No need for the pipe operator in this line
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to fix #1076
Tests are passing on both, case-sensitive system (Arch Linux with ext4) and case-insensitive system (OSX with ... uhm, their FS). Also, a warning is now correctly displayed on OSX.
I adjusted the test to cover this case as well, however, it doesn't really prove much. Not sure if this suffices or if we have to think of some way to actually make this behaviour testable on any system. - I couldn't think of an easy way of simulating the case-insensitive behaviour on my work machine / the CI)