Skip to content

Loosen tree-sitter library bounds. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Loosen tree-sitter library bounds. #36

merged 1 commit into from
Apr 28, 2022

Conversation

patrickt
Copy link

The grammars should work fine with 0.19.

The grammars should work fine with 0.19.
@the-mikedavis
Copy link
Member

The only thing I know is a little rough on older tree-sitter versions for this grammar is this: tree-sitter/tree-sitter#1444. Since tree-sitter-elixir uses newlines as extras and as non-extra rules (_terminator), an incremental change can end up putting the tree into an odd state on tree-sitter < 0.20.1. Incremental changes are not necessarily part of everyone's workflows though so I think it's ok 👍

@patrickt
Copy link
Author

@the-mikedavis Makes sense; I think people who hit the incrementality bug can upgrade themselves (we’re stuck on 0.19, at least for now). I don’t have merge permissions on here, would you mind doing so (or adding me)?

@the-mikedavis the-mikedavis merged commit 5d0c1bf into elixir-lang:main Apr 28, 2022
@patrickt patrickt deleted the patch-1 branch April 28, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants