use size_t to store allocated size #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if there is a test we can do to ensure this doesn't happen again. I believe this is the right solution. I think the only way would be to compile in arm64 and run the tests on that architecture. Wonder how hard that is to do with github actions? |
|
I might be wrong but I don't think it's arm64 specific. The pointer was misaligned on x86_64 as well, it's just that C and SQLite didn't care about it and Zig did (maybe because Zig uses SSE instructions in its standard lib, but those require 16-byte alignment...). |
|
Ah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #209