Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Dogma fixes #31

Merged
merged 2 commits into from
Oct 13, 2015
Merged

Dogma fixes #31

merged 2 commits into from
Oct 13, 2015

Conversation

mmmries
Copy link
Collaborator

@mmmries mmmries commented Oct 12, 2015

This updates Dogma to work with elixir 1.1.0 and defines our own RuleSet. Currently we can't configure the line length without just re-defining our own ruleset. The Dogma team is currently working on this: lpil/dogma#70

So in the meantime I just copied and pasted the Dogma.RuleSet.All and changed the line length configuration to 100 chars per line.

Ignoring the test_database.exs file and set max line length to 100 chars reduces our errors from 289 down to 44 errors.

@mmmries
Copy link
Collaborator Author

mmmries commented Oct 13, 2015

@jazzyb @obmarg either of your have objections to this?

@obmarg
Copy link
Collaborator

obmarg commented Oct 13, 2015

Seems reasonable to me.

mmmries added a commit that referenced this pull request Oct 13, 2015
@mmmries mmmries merged commit ee3f5d0 into master Oct 13, 2015
@mmmries mmmries deleted the dogma_fixes branch October 13, 2015 21:49
@lpil
Copy link
Contributor

lpil commented Oct 24, 2015

Hey guys. Configuration of rules without defining a ruleset is now on master. I need to test it a bit before I release it, but it'll be on hex soon.

config :dogma,
  rule_set: Sqlitex.DogmaRuleSet,

  exclude: [
    ~r(\Atest/test_database.exs),
  ]

  override: %{
    LineLength => [max_length: 100],
  }

P.S. Thanks for using Dogma. :)

@mmmries
Copy link
Collaborator Author

mmmries commented Oct 24, 2015

That's great to hear. I'll check on it soon and switch this to configure
without a ruleset.
On Oct 24, 2015 11:49 AM, "Louis Pilfold" notifications@github.com wrote:

Hey guys. Configuration of rules without defining a ruleset is now on
master. I need to test it a bit before I release it, but it'll be on hex
soon.


Reply to this email directly or view it on GitHub
#31 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants