Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Fix doctests #40

Merged
merged 3 commits into from
Sep 16, 2016
Merged

Fix doctests #40

merged 3 commits into from
Sep 16, 2016

Conversation

mmmries
Copy link
Collaborator

@mmmries mmmries commented Sep 16, 2016

Fixes #39

Also updates the erlang/elixir versions that we run on travis and ignores the mix.lock from the git repo.

/cc @jazzyb @obmarg

@obmarg
Copy link
Collaborator

obmarg commented Sep 16, 2016

What's the thinking behind ignoring mix.lock? Always thought that was meant to be in the git repository. To quote the getting started guide:

You will notice that when you add a dependency to your project, Mix generates a mix.lock file that guarantees repeatable builds. The lock file must be checked in to your version control system, to guarantee that everyone who uses the project will use the same dependency versions as you.

@mmmries
Copy link
Collaborator Author

mmmries commented Sep 16, 2016

@obmarg the reasoning is so that travis will always build with the latest version of each of our dependencies (within the constraints that we declare in mix.exs). I started ignoring my Gemfile.lock files when I publish ruby gems a while ago because it helped me see breakages between my code and other dependent libraries before I released updates.

My rule of thumb is that I usually include lock files in git repos for my applications, but I ignore them in my published libraries because the users of my library will always resolve their own dependencies so I only want to rely on the constraints that I define in my library.

@obmarg
Copy link
Collaborator

obmarg commented Sep 16, 2016

Fair enough. Looks good to me then.

@mmmries mmmries merged commit ef1fd45 into master Sep 16, 2016
@mmmries mmmries deleted the fix_doctests branch September 16, 2016 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants