Skip to content
This repository was archived by the owner on Mar 19, 2021. It is now read-only.

Conversation

dominicletz
Copy link
Contributor

New function in Server that allows submitting jobs async. Initially this was a GenServer.cast, but I've added batching, so that if many async queries are pending they will be submitted in a single sqlite transaction. Which depending on your sqlite journaling mode can have significant performance impacts.

@coveralls
Copy link

coveralls commented Aug 11, 2020

Coverage Status

Coverage decreased (-6.4%) to 86.818% when pulling 14fffd6 on diodechain:query_async into 1d47a6b on elixir-sqlite:master.

Copy link
Member

@ConnorRigby ConnorRigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this looks like a useful feature.
Would you mind adding a test?

@dominicletz
Copy link
Contributor Author

dominicletz commented Aug 11, 2020

Yeah, I wanted to get rid of my own fork with those changes, so I created a bunch of pulls today. I'm bit test-lazy, but give me a couple of days and i might do it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants