Skip to content

Conversation

LVala
Copy link
Contributor

@LVala LVala commented Jul 9, 2024

No description provided.

@LVala LVala self-assigned this Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 36.53846% with 33 lines in your changes missing coverage. Please review.

Project coverage is 86.22%. Comparing base (0eb774c) to head (cfc7392).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   87.16%   86.22%   -0.95%     
==========================================
  Files          36       36              
  Lines        1854     1887      +33     
==========================================
+ Hits         1616     1627      +11     
- Misses        238      260      +22     
Files Coverage Δ
lib/ex_webrtc/rtp_sender.ex 87.71% <63.63%> (-3.95%) ⬇️
lib/ex_webrtc/rtp_receiver.ex 66.66% <36.36%> (-4.35%) ⬇️
lib/ex_webrtc/rtp_transceiver.ex 87.00% <40.00%> (-4.36%) ⬇️
lib/ex_webrtc/peer_connection.ex 81.37% <13.33%> (-0.68%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb774c...cfc7392. Read the comment docs.

@LVala LVala marked this pull request as ready for review July 9, 2024 13:44
@LVala LVala requested a review from mickel8 July 9, 2024 13:44
Comment on lines +28 to +29
retransmitted_packets_sent: non_neg_integer(),
retransmitted_bytes_sent: non_neg_integer(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: we can make this a bit shortert

Suggested change
retransmitted_packets_sent: non_neg_integer(),
retransmitted_bytes_sent: non_neg_integer(),
rtx_packets_sent: non_neg_integer(),
rtx_bytes_sent: non_neg_integer(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stat from W3C, so I'd probably leave it as it is for the sake of compatibility. If it was for me to decide, I'd also use rtx_ prefix.

@LVala LVala merged commit 3afedc6 into master Jul 10, 2024
@LVala LVala deleted the stats branch July 10, 2024 10:19
@LVala LVala mentioned this pull request Jul 10, 2024
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants