Update implementation of __info__ #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds further support for more "kinds" from __info__. It works by getting the data from the current module and then compiling the values.
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
|
|
||
| # Builds the __info__ function that Elixir modules | ||
| # have. | ||
| defp make_info_function() do |
There was a problem hiding this comment.
Do not use parentheses when defining a function which has no arguments.
| @@ -61,7 +61,7 @@ defmodule ElixirScript.Translate.Module do | |||
| _ -> | |||
| { compiled_functions, _ } = Enum.map_reduce(combined_defs, state, &Function.compile(&1, &2)) | |||
|
|
|||
| compiled_functions = compiled_functions ++ [make_info_function(module, defs, state)] | |||
| compiled_functions = [make_info_map(module, state)] ++ compiled_functions ++ [make_info_function()] | |||
There was a problem hiding this comment.
Line is too long (max is 80, was 107).
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixirscript/elixirscript/pulls/378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds further support for more "kinds" from info.
It works by getting the data from the current module and then
compiling the values.