Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow follow with notify = true #538

Closed
Shinigami92 opened this issue Dec 24, 2022 · 4 comments · Fixed by #1045
Closed

Allow follow with notify = true #538

Shinigami92 opened this issue Dec 24, 2022 · 4 comments · Fixed by #1045
Assignees
Labels
c: feature Request for new feature good first issue Good for newcomers

Comments

@Shinigami92
Copy link
Member

In Mastodon it's possible to follow someone with notify active:
image

POST https://:instance/api/v1/accounts/:id/follow
Body: {"notify":true}


Currently I need to open the profile in original site, and if this is not my instance I need to re-search the account manually in my instance to reach this notify bell
It should somehow be possible to use this in elk directly

@Shinigami92 Shinigami92 added the c: feature Request for new feature label Dec 24, 2022
@Shinigami92 Shinigami92 moved this to Todo in Elk Roadmap Dec 24, 2022
@zyyv zyyv moved this from Todo to In Progress in Elk Roadmap Dec 29, 2022
@zyyv zyyv moved this from In Progress to Todo in Elk Roadmap Dec 29, 2022
@jeffsikes
Copy link
Contributor

Came here to request the same, thanks @Shinigami92

@Shinigami92 Shinigami92 added the good first issue Good for newcomers label Jan 11, 2023
@jeffsikes jeffsikes self-assigned this Jan 12, 2023
@jeffsikes jeffsikes pinned this issue Jan 12, 2023
@jeffsikes
Copy link
Contributor

I've started the branch feat/538-notify-me-when-account-posts with my changes. This is my second ever attempt at a code contribution to an open source project so please be kind. 😄

Verified the correct endpoint is called and value is updated, but the phrasing of the command may need to be tweaked a bit.

I tried to stick with similar text phrasing as other commands in the list. Also to match the official Mastodon terminology. The phrase is quite long. Some apps have shifted this option outside of the hamburger menus and placed it as a bell icon right beside it.

Other phrase options I considered:

  • "Enable notifications" / "Disable notifications"
  • "Enable alerts for {0}" / "Disable alerts for {0}"
  • "Enable alerts" / "Disable alerts"
  • "Notify me when {0} posts" / "Stop notifying me when {0} posts" (official phrase from Mastodon)

I figured it might be setup with the account name in most commands to assist with text readers.

Enable action presented when notifications are currently off
image

Disable action presented when notifications are currently active
Disabled State

@Shinigami92
Copy link
Member Author

@jeffsikes currently the branch you linked is just 3 commits behind and has no changes from you
So maybe you need to commit and push changes from your local machine
After doing that please open a pull request (PR) and if you are still working on it, you have the possibility to mark it as "draft"-PR
Creating a draft PR has the benefit that we can already start commenting on lines in the PR itself to guide and help

@sxzz sxzz unpinned this issue Jan 12, 2023
sxzz pushed a commit that referenced this issue Jan 13, 2023
Co-authored-by: 三咲智子 Kevin Deng <sxzz@sxzz.moe>
Fix #538
@github-project-automation github-project-automation bot moved this from Todo to Done in Elk Roadmap Jan 13, 2023
@jeffsikes
Copy link
Contributor

jeffsikes commented Jan 13, 2023

Wanted to mention here that after discussion, the option was moved up in to the UI of the Account header beside the Follow button, so the action is now visible when viewing any account you currently follow, hidden otherwise.

Screenshot 2023-01-12 at 5 34 35 PM

May want to enhance this in the future in the following ways:

  • Attach accessibility tags for the button (aria-label and title)
  • Duplicate the feature in the more dropdown to provide more detail on the action (it exists as a bell icon and as a dropdown item)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature good first issue Good for newcomers
Projects
Status: Done
2 participants