-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refetch home page when click elk logo #1129
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the full page reload should be fixed, but not sure if it makes sense to serve the logo as a refresh button instead of "Go to home page"?
Would it make more sense to use the home button rather than the elk logo? Mobile devices cannot benefit from this feature since there's no elk logo at all, also considering currently there's no way to refresh timeline in PWA other than killing and relaunching the app. |
In this PR, the link behavior is "Go to homepage" if the user is not on the homepage, otherwise "Refetch timeline data" if the user is on the homepage, is this PR title inaccurate ? |
# Conflicts: # components/common/CommonPaginator.vue
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I now get a blank timeline if I open the preview, scroll down a bit, and then press the logo. |
This solved! |
In the current version, clicking the Elk Logo in the navigation bar will reload the entire page.
2023-01-15.12.41.53.mov
According #86, this is to expect that when the Logo is clicked, page will jump to top and refresh timeline to latest.
I try to refactor it with nuxt hook to avoid refetching the whole page.
2023-01-15.12.49.39.mov