Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recover Search/Explore pages separation #2064

Closed
wants to merge 3 commits into from
Closed

feat: recover Search/Explore pages separation #2064

wants to merge 3 commits into from

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented May 5, 2023

This resolves #2063

Example screenshots

Before (previous /explore and new /explore/posts page)
Screenshot 2023-05-05 at 16 32 22

After (new /explore page)
Screenshot 2023-05-05 at 16 31 52

@stackblitz
Copy link

stackblitz bot commented May 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 44d1763
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/64572fe32c7b2f0008176ed8

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 44d1763
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/64572fe37689dc0008340fc2
😎 Deploy Preview https://deploy-preview-2064--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shuuji3 shuuji3 changed the title feat: add well-being preference to hide trends posts feat: add well-being preference to hide trends posts by default on Explore page May 5, 2023
@patak-dev
Copy link
Member

I don't think we need a new option. We wanted to revert the change that merged explore and search but never got to it. See #1301 (comment). There is an open PR but I think it isn't working right #1704.

@shuuji3 could you remove the new option and directly revert what was done regarding the merge of explore/search in #1301 (there are other things too in that PR)? Or maybe yours already work if you remove the option.

@shuuji3
Copy link
Member Author

shuuji3 commented May 5, 2023

Ah, thanks for pointing out. I missed that discussion. I'm going to remove the option and hide the trends post by default at first as it's easier to modify.

But it would be slightly different from the previous state so after that, I'll check #1704 and update the code to restore the previous behavior later.

@patak-dev
Copy link
Member

Ok, no rush. Lets merge this one once the search route and explore route are completely separated to avoid glitches in https://main.elk.zone

@shuuji3 shuuji3 marked this pull request as draft May 5, 2023 16:46
@shuuji3 shuuji3 changed the title feat: add well-being preference to hide trends posts by default on Explore page feat: recover Search/Explore pages separation May 5, 2023
@Shinigami92 Shinigami92 added the c: feature Request for new feature label May 5, 2023
@shuuji3
Copy link
Member Author

shuuji3 commented May 7, 2023

44d1763 is an incomplete change so it's better to adopt #2075.

@shuuji3 shuuji3 deleted the feat/wellbeing-hide-popular-posts branch May 7, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

New well-being preference: Hide trends posts on Explore page by default
3 participants