-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recover Search/Explore pages separation #2064
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I don't think we need a new option. We wanted to revert the change that merged explore and search but never got to it. See #1301 (comment). There is an open PR but I think it isn't working right #1704. @shuuji3 could you remove the new option and directly revert what was done regarding the merge of explore/search in #1301 (there are other things too in that PR)? Or maybe yours already work if you remove the option. |
Ah, thanks for pointing out. I missed that discussion. I'm going to remove the option and hide the trends post by default at first as it's easier to modify. But it would be slightly different from the previous state so after that, I'll check #1704 and update the code to restore the previous behavior later. |
Ok, no rush. Lets merge this one once the search route and explore route are completely separated to avoid glitches in https://main.elk.zone |
This resolves #2063
Example screenshots
Before (previous
/explore
and new/explore/posts
page)After (new
/explore
page)