feat: inline some mentions to reduce spacing #1307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #1293 (and 5785047), if you add a new mention in a conversation, a
mention-group
will be created only with it as the others are removed from the context. This could break the context, especially now that we edit with the grouped mentions so people may start using the initial handle as part of the text. But the main issue to me is that amention-group
that only has one or two handles ends up occupying more space extracted than inlined.This PR lets mentions be inlined when only 1 or 2 remain to be shown and creates a
mention-group
when there are 3 or more.Elk 0.5.0
Elk before this PR
After this PR