Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap 1.0 #2

Closed
norv opened this issue Nov 30, 2012 · 39 comments
Closed

Roadmap 1.0 #2

norv opened this issue Nov 30, 2012 · 39 comments
Labels
Milestone

Comments

@norv
Copy link
Contributor

norv commented Nov 30, 2012

The following are the main targets for 1.0 beta.
These targets are in three main categories:

emanuele45 added a commit that referenced this issue Dec 19, 2012
@Spuds
Copy link
Contributor

Spuds commented Dec 21, 2012

Things to add and/or contemplate.

  1. Our directory structure
  2. update parse_bbc (maybe to much for 1.0?)
  3. remove openID? / add in other credential services e.g. google ?
  4. utf8 only
  5. karma refresh

@emanuele45
Copy link
Contributor

/me feels the one above is a github bug! :D

@norv
Copy link
Contributor Author

norv commented Dec 22, 2012

Yup it must be a github bug, it messed up when your PR was merged in. Next time I'll try to do this differently than PR to your branch.

@norv
Copy link
Contributor Author

norv commented Dec 22, 2012

  1. update parse_bbc (maybe to much for 1.0?)

I don't know... if it's too much. Many stuffs to do, and some folks are so lazy. (points as self). It's awesome if we manage to though, imho.

@emanuele45
Copy link
Contributor

But in theory should be the correct way...isn't it?

/me looks for a github bug tracker... O:)

@norv
Copy link
Contributor Author

norv commented Dec 22, 2012

I thought I knew it was one (or was I dreaming)... I am only finding a mention that sayz:

If you find a bug, submit it to support@github.com. Every email is read by a real person.

Yes... methinks we did nothing wrong, it just got dizzy cuz it's the same issue number for a forked repo and for the main repo. (apparently no other reference is stored)

@Spuds
Copy link
Contributor

Spuds commented Dec 22, 2012

Spammers .. git yer own issue 👅

  • fix the way avatars are served from the system

@emanuele45
Copy link
Contributor

A forum is not enough for us! :P

@norv
Copy link
Contributor Author

norv commented Dec 23, 2012

Updated the issue. 😆

@Spuds
Copy link
Contributor

Spuds commented Dec 25, 2012

We talked about adding in a form validation class as well, move all those various form checks to a single location / class

@norv
Copy link
Contributor Author

norv commented Jan 19, 2013

Added validation.

Proposed functionality: email to post and viceversa. Interoperability with email.

@norv
Copy link
Contributor Author

norv commented Jan 25, 2013

I documented the targets (the general look) of the architecture/code design refactoring at https://github.com/elkarte/Elkarte/wiki/Architecture

@Spuds
Copy link
Contributor

Spuds commented Feb 9, 2013

Proposed functionality: email to post and viceversa. Interoperability with email.

Been working on this one ... should have a branch for all to contemplate in a few days.

@norv
Copy link
Contributor Author

norv commented Feb 9, 2013

Speaking of validation, SpudsMan, we will also add your awesome validation class?
I think it would be much better to have it in for beta, to start using it and improving it. I'm sure it will make a difference at several levels - in the wide range from security to code readability.

@Spuds
Copy link
Contributor

Spuds commented Feb 10, 2013

We certainly can ... as you noted the big effort with that is incorporating it and figuring out what checks make the most sense to include, etc. I had started with some of the standard/obvious ones and then added in some of the regex ones (that appear multiple times in the code) ... But we can't do any of that unless we include it of course. I'll make a PR on it as the class itself so we can begin to integrate it and figure out how best improve it.

@norv
Copy link
Contributor Author

norv commented Feb 13, 2013

Added to the list:

On a side note. It would be awesome and needed, IMHO, to make a wiki page documenting these features, enhancements, and the general improvements we make to the code. Some of those in the first post are already in, and the post clarifies which is already done. (I hope)

norv added a commit that referenced this issue Mar 12, 2013
@norv
Copy link
Contributor Author

norv commented May 9, 2013

Re: default theme.

Can we pick and replace the default theme?

@eurich
Copy link
Member

eurich commented May 9, 2013

Re: default theme
Is Ant (or anyone else) currently working on this one?

@norv
Copy link
Contributor Author

norv commented May 9, 2013

No, the White Minimalistic theme is the candidate. (IMO).
Curve II and Classic don't seem appropriate, nor color variations of them (IMO again). @Spuds was also working on something, afaik a color variation: https://github.com/Spuds/Elkarte/commits/terra

@emanuele45
Copy link
Contributor

ehm....minimalistic is a color variation of Curve II. 👼

@norv
Copy link
Contributor Author

norv commented May 9, 2013

🌴

@eurich
Copy link
Member

eurich commented May 9, 2013

I agree with Norv, white minimalistic should be default (instead of Curve II). we should drop Curve Classic and offer one or two color variants based on minimalistic by default.

@Spuds
Copy link
Contributor

Spuds commented May 9, 2013

Pick one, but lets be sure and change paths again in a few months so we never really make any progress ... keeps everyone sharp I say.

@norv
Copy link
Contributor Author

norv commented May 13, 2013

Want to do the honors, SpudsMan? Curve II and Classic are mostly yours, me not even knows what's in that shiny themey stuff and why.

@Spuds
Copy link
Contributor

Spuds commented May 13, 2013

My ability to choose the "wrong" theme and then spend countless hours for naught is legendary at this point 👅 so for this theme round I will stand on the sideline and watch. Curve reborn and classic should be shifted over to the theme graveyard and removed from master in favor of whatever is chosen.

@eurich
Copy link
Member

eurich commented May 13, 2013

I think the primarily issue with Curve reborn is the color set (SMF's light blue an orange, Elk really shouldn't use the same colors as SMF 2.1). Ema's minimalistic (AFAICS) IS Curve reborn, but without colors.. That's the perfect base for themers, but IMO it is too dull to be the one and only default layout..So we'd need Curve reborn (with a new color set tba) and minimalistic as a second color set?

@emanuele45
Copy link
Contributor

Variants?

@eurich
Copy link
Member

eurich commented May 13, 2013

yep, that's what I meant 👍

@Spuds
Copy link
Contributor

Spuds commented May 13, 2013

I agree ... but I'm terrible with colors and e-man does not like color at all, so I hope eurich has some ideas 🙇

@emanuele45
Copy link
Contributor

/me is mostly color-blind (even though I'm not... 👼 )

@eurich
Copy link
Member

eurich commented May 13, 2013

LOL
I'm not a designer but yes, I have at least some ideas how it could be done.. minimalistic would need some smaller changes, a light grey and a somewhat darker grey instead of the light blue and orange links and buttons? @emanuele45: is that ok for you?

white and grey fits IMO in almost any other color (maybe three variants: a blue, a red and a green one) ?

green: #9cc060
blue: #3e5a78 <-- that's the current footer color
red: #dd0b38
In order to get some contrasts we could use some complementary colors, would need to test it ..

Do you prefer warm or cold color types?

@norv
Copy link
Contributor Author

norv commented May 14, 2013

... Cold? :) /me proves evilness all 'round.

@eurich
Copy link
Member

eurich commented May 14, 2013

methinks Norv would be happy with a "welcome in hell" variant (black and red with fire & flames, with Hades for the logo) ;)

@Spuds
Copy link
Contributor

Spuds commented May 14, 2013

I'd consider looking at something like http://www.visibone.com/color/card_800.gif ... (sorry so so pic). Its a color chart that provides the "safe" colors to use if we want to take in to consideration the 8+% of the population that is color blind in one form or another. Using the colors on this chart (for the major things) will result in things looking the same for everyone.

And I am color blind, fail all the tests, which is why my clothes from the 70's are still fab baby 👅

@eurich
Copy link
Member

eurich commented May 14, 2013

yep, will check .. thank you :) Would be good, if someone (@emanuele45?) could push the minimalistic as default. Could grab it from the themes repo too, but maybe there's a newer version?

@emanuele45
Copy link
Contributor

mmm...now I have a bit of a mess because I just finished to set up my dev environment in a sort of logical way, so I'm not sure what's more advanced... lol
I think this one is fine:
https://github.com/emanuele45/Dialogo/tree/minimalist

But I'm not yet sure if you want also all the fancy jQuery hide/show effects. If not, it's probably easier to just grab the css and commit it again...

@norv
Copy link
Contributor Author

norv commented May 15, 2013

now I have a bit of a mess / because I just finished to set up my dev environment in a sort of logical way

/me tries to parse the phrase and gets an error... 👼

@emanuele45
Copy link
Contributor

1.0 Beta milestone closed.

1.0 Final is the current reference.

@emanuele45
Copy link
Contributor

At that point I feel this one can be closed pending release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants