-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default avatar feature :) #152
Conversation
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Rebase has changed the commits hashes, that's why it's doing the trick on you... The quickest way is to just force, as above.
You can, if you wish, take them from temp_avatar, to default_avatar, too:
You can, if you wish, merge (not rebase) now, your master, to the local default_avatar. And push it back on github. |
Thanks you for the details.. I'm still a git noob :P |
Cool and handy, thank you! :) |
upgrade_files aren't planned for upgrading smf to elk? If so, I'll revert those commits / remove that code and let the changes only stay in the install files.. Are you fine with the other code for now? Note: I have plans to add a new function detect_avatar_type() for the next pull request (gravatar_support) once this one gets merged. The current code for avatar detection is almost unreadable, at least for me :P |
Yes, they are (sort of). |
mhh, from my understanding this is how it works in SMF: Which files in Elk will do the following task?
hahaha, now I'm completely confused.. |
Nope. Note: upgrade_dia_1-0_dbtype.sql should be renamed to upgrade_elk_1-0_dbtype.sql or upgrade_elkarte_1-0_dbtype.sql |
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
arg, need to update again.. lost the dia ugrades due to a --reset at some point :-/ |
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
ok, I think all should be in place now :) |
Thank you! |
I'm not 100% happy with the changes in Load.php related to $memberContext[$user]['avatar'] however it's to complicated to add it to the current checks (line 1116 ff)
Please review the texts carefully, my english is still horrible :P
Gravatars will follow soon :)