-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to 1.80.1 toolchain; dependency updates #1144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
co-authored-by: Johan Geluk <johan@geluk.io>
w-lfchen
commented
Aug 1, 2024
pub fn put_back(&mut self, ast: Ast) { | ||
pub fn put_back(&mut self, ast: Ast) -> Option<Ast> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API change for more flexibility, doesn't cause issues
everything should be up to date at the time of writing this |
13 tasks
3 tasks
2 tasks
3 tasks
w-lfchen
changed the title
feat: update to 1.80.0 toolchain; dependency updates
feat: update to 1.80.1 toolchain; dependency updates
Aug 15, 2024
Thank you so much for your work! |
1 task
This was referenced Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
specific details on some crate updates can be found below
motivated by and closes #1141
closes #1156
motivated by NixOS/nixpkgs#332957 (eww is currently building in nixpkgs through a lockfile patch)
supersedes #1137 (patch has been applied in a004136)
supersedes #809 (see below), therefore also closes #808
basic functionality tested (systray not tested, my config does not contain one)
reduces build times by dropping ~40 crates in the dependency tree
note: there are warnings about unused struct fields now, this probably should be addressed
dbusmenu-glib
breaks when automatically updating the missing dependenciesi don't know enough about this to even attempt to fix it, but i'd love to integrate a fix before opening this pr.
after 4cf9d2d
running
cargo update --dry-run
yields the following:When adding these crates by simply running
cargo update
,dbusmenu-glib
fails to compile:there are multiple errors like this one, since the
dbusmenu-gtk3
crate and a few others that seem to be linked to it are auto-generated, something probably needs to be adjusted in the generation process.before 4cf9d2d
running
cargo update --dry-run
yields the following:note that everything seems to work without them and that
gdk-pixbuf-sys
seems to depend on the other 3.When adding these crates,
dbusmenu-glib
fails to compile:there are multiple errors like this one.
re-enable grass default features
80a5a45 re-enabled default features.
running
cargo clean && cargo build
produced the exact same compilation times for me, so the argument brought up in #606 no longer holds.derive_more v1.0.0
the most notable breaking change is that now, all features should be enabled manually, which i've done.
Checklist
cargo fmt
to automatically format all code before committingnix fmt
to automatically format all code before committing