Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haxe 4 / dev branch support #26

Closed
Gama11 opened this issue Jun 27, 2017 · 5 comments
Closed

Haxe 4 / dev branch support #26

Gama11 opened this issue Jun 27, 2017 · 5 comments

Comments

@Gama11
Copy link
Contributor

Gama11 commented Jun 27, 2017

Because of HaxeFoundation/haxe#6380, json2object needs an update to support Haxe 4. Ideally, the haxe_ver defines is checked (example) to support both Haxe 4+ and 3.4.

@ibilon
Copy link
Collaborator

ibilon commented Jun 27, 2017

Tried in 07e52e0, it fixes the issue but I'm seeing some inconsistencies in the tests on different targets.
Some say null should 0 or null should be [] but not all.

Also is the haxe_ver check necessary? There's either the null abstract or null typedef, so there shouldn't be any conflict in checking both.

@Gama11
Copy link
Contributor Author

Gama11 commented Jun 27, 2017

Hm, right, might not be necessary.

@ibilon
Copy link
Collaborator

ibilon commented Jun 27, 2017

Done in 6d0c25e

@ibilon ibilon closed this as completed Jun 27, 2017
@Gama11
Copy link
Contributor Author

Gama11 commented Jun 27, 2017

Hm, something seems to be broken.. will look into it later. https://travis-ci.org/vshaxe/vshaxe#L677

@Gama11
Copy link
Contributor Author

Gama11 commented Jun 28, 2017

Nvm, that was actually an issue with the macros in haxe-formatter, which also needed an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants