Simplified barrier logic #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 30, 2015 12:24
| select { | ||
| case <-zkMemberJoinedWatcher: | ||
| continue | ||
| } |
There was a problem hiding this comment.
Shouldn't this select also have a case <-stopChan? It looks it might block here indefinitely
There was a problem hiding this comment.
Good thinking. I've added the case <- stopChan on the inner select statement.
Merge pull request #126 from CrowdStrike/more-zk-logging
…one host cannot reach consesus on a state barrier and gets stuck in a loop.
| // Haven't seen all expected consumers on this barrier path. Watch for changes to the path... | ||
| select { | ||
| case <-stopChan: | ||
| return |
There was a problem hiding this comment.
Suppose we should have that blackhole function to read from zkMemberJoinedWatcher here as well. Consider a following case: we create a zkMemberJoinedWatcher and hit the barrier timeout; the stopChan receives a value but then a member joins; zk lib tries to write to zkMemberJoinedWatcher but no one listens to it anymore. At this point zk lib would probably block indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the logic for how we await on a state barrier easier.
The client first creates/joins the barrier in a blocking call. Afterwards we kick off a go routine that loops with a zkwatcher on the barrier zkNode and doesn't notify the AwaitOnStateBarrier func until either it sees all expected clients or gets an error.