Skip to content

Add option to disable completion in comments #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2021
Merged

Add option to disable completion in comments #141

merged 1 commit into from
Dec 6, 2021

Conversation

michaelpj
Copy link
Collaborator

Doesn't fix #135 per se but at least allows people to pick which
annoyance they want.

@michaelpj
Add option to disable completion in comments
988755d 
Doesn't fix emacs-lsp#135 per se but at least allows people to pick which
annoyance they want.
@michaelpj michaelpj merged commit 9fbe4d3 into emacs-lsp:master Dec 6, 2021
michaelpj added a commit to michaelpj/lsp-haskell that referenced this pull request Dec 6, 2021
@michaelpj
Revert "Merge pull request emacs-lsp#141 from michaelpj/mpj/completio…
bbb8bc1 
…n-in-comments"

This reverts commit 9fbe4d3, reversing
changes made to 4e62cf8.
@alanz
Copy link
Contributor

alanz commented Dec 6, 2021

I am getting Error (use-package): lsp-haskell/:catch: Symbol’s function definition is void: lsp-haskell-completion-in-comments after this landed

@michaelpj
Copy link
Collaborator Author

Just fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completion in comments is annoying
2 participants
@michaelpj @alanz