Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size of lightbulb.png is too big 128x128px. #570

Closed
segitwo opened this issue Feb 6, 2021 · 13 comments
Closed

Size of lightbulb.png is too big 128x128px. #570

segitwo opened this issue Feb 6, 2021 · 13 comments

Comments

@segitwo
Copy link

segitwo commented Feb 6, 2021

No description provided.

@segitwo segitwo changed the title Size of lightbulb.png is too big 128x128. Size of lightbulb.png is too big 128x128px. Feb 6, 2021
@ericdallo
Copy link
Member

ericdallo commented Feb 7, 2021

Yeah, the ideal sould be to replace it with a .svg, not sure emacs supports svg though

@sebastiencs
Copy link
Member

What is the issue with that size ?
The image is resized (to make it smaller) and visually it should fits in the line.

By using a smaller size, the image would have to be resized too, but by making it bigger and it would appear pixelated.

Yeah, the ideal sould be to replace it with a .svg, not sure emacs supports svg though

Emacs does support svg images, but it requires a compile time flag, and not all linux distribution package Emacs with that flag

@shadyalfred
Copy link

image

When I hover over lines with errors or warnings, the height of the lines increases, then when I move away it decreases. It is kinda annoying seeing the lines glitching like this.

@hammerandtongs
Copy link

This is pretty painful as is.

The lightbulb is about 5 lines tall and it causes the text to jump around it as i scroll along.

Is there a simple way to disable the lightbulb for now?

@sebastiencs
Copy link
Member

@shadyalfred @hammerandtongs Can you please post the value of those 3 variables:
system-configuration, system-configuration-options and system-configuration-features

You can disable it with (setq lsp-ui-sideline-actions-icon nil)

@shadyalfred
Copy link

system-configuration
image

system-configuration-options
image

system-configuration-features
image

@hammerandtongs
Copy link

"x86_64-pc-linux-gnu"

"--build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/26.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.3/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/26.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.3/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs-mEZBk7/emacs-26.3+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro'"

"XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD LCMS2"

@padraic00
Copy link

Any updates on this?

@yyoncho
Copy link
Member

yyoncho commented Feb 18, 2021

@jcs090218 is this fixed with 63533f1 ?

@jcs090218
Copy link
Member

@jcs090218 is this fixed with 63533f1 ?

@yyoncho I did fix the glitch.


But since there is no description from the author so I don't know if I should close this issue.

@padraic00 Can you update to the latest version and see does the commit 63533f1 suit your needs? Thanks!

@padraic00
Copy link

padraic00 commented Feb 19, 2021

@padraic00 Can you update to the latest version and see does the commit 63533f1 suit your needs? Thanks!

currently on 78e0a41. Still unfixed.

System Info 💻

  • OS: darwin
  • Emacs: 26.3
  • Spacemacs: 0.300.0
  • Spacemacs branch: develop (rev. e4452f9a8)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • System configuration features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS LCMS2

@ericdallo
Copy link
Member

Alright, @yyoncho @jcs090218 since the issue is not solved, can we disable that icon by default and re-enable it when fixed?
We already have #573 and emacs-lsp/lsp-mode#2628, so it seems to affect multiple users

@jcs090218
Copy link
Member

Let's move this issue to #573 since I think it has a better bug report. :)

Close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants