[lsp-ui-doc] Wrap lines when not using childframes #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not using childframes, lsp-ui-doc contents should be wrapped according to lsp-ui-doc-max-width.
MaskRay
reviewed
Sep 30, 2018
lsp-ui-doc.el
Outdated
| (if (lsp-ui-doc--inline-p) | ||
| (progn (let ((fill-column lsp-ui-doc-max-width)) | ||
| (fill-region (point-min) (point-max))) | ||
| (buffer-substring (point-min) (point-max)))) |
There was a problem hiding this comment.
Why do you need (buffer-substring (point-min) (point-max))? The return value is not used.
I think you may use: when + fill-region
|
@MaskRay good question. This was me pulling something from elsewhere for line wrapping strings. I’ve updated with your your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not using childframes, lsp-ui-doc contents should be wrapped according to
lsp-ui-doc-max-width.Currently very long lines will result in a overlay that spans the entire width of the window that has truncated lines, eg.
This is not helpful as the content is truncated and it also results in an inconsistent look.
Instead I think the overlay should be limited in width according to
lsp-ui-doc-max-wdithresulting in the following:I’m quite new to elisp, so please let me know how I can improve my changes if needed. Thanks!