Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #491: Remove eager syntax-propertize #508

Closed
wants to merge 1 commit into from
Closed

Fix #491: Remove eager syntax-propertize #508

wants to merge 1 commit into from

Conversation

mallt
Copy link
Contributor

@mallt mallt commented May 2, 2019

This PR fixes #491 by removing the eager syntax-propertize since emacs now calls syntax-propertize automatically on-demand during forward.

@mallt
Copy link
Contributor Author

mallt commented May 2, 2019

I will take a look at the failing tests

@mallt
Copy link
Contributor Author

mallt commented May 22, 2019

@zonuexe I think we can close this PR in favor of #531?

@zonuexe
Copy link
Member

zonuexe commented May 23, 2019

@mallt
Thank you for organizing the discussion!
I also tried some implementations, but this change was better.

@mallt
Copy link
Contributor Author

mallt commented May 23, 2019

@zonuexe Ok perfect, thanks a lot!

@mallt mallt closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

php-mode's call to php-syntax-propertize-function makes visiting large files rather slow
2 participants
@mallt @zonuexe