handle NIL in LSUB in addition to LIST too. #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And to be clear, the Gaia email app is able to successfully sync our folder list with this patch and the previous patch applied as well. |
andris9
added a commit
that referenced
this pull request
Sep 24, 2014
handle NIL in LSUB in addition to LIST too.
asutherland
added a commit
to asutherland/gaia-email-libs-and-more
that referenced
this pull request
Nov 20, 2014
This is primarily a move to the upgrade startTLS functionality. This included a fix to the SMTP implementation where a server could avoid TLS-initiation by not implementing EHLO. (emailjs/emailjs-smtp-client#20). This goal was bug 1060558. An additional fix we had made locally but not upstreamed (but have now upstreamed) and that has improved test coverage on our end (see test_mine) is a problem relating to newlines. See emailjs/emailjs-imap-client#35. Other (new) fixes folded in here: - Namespace NIL delimiter: emailjs/emailjs-imap-client#36 - trailing whitespace in bodystructure list: emailjs/emailjs-imap-handler#8 Fixes we had made locally and upstreamed but not taken via the release process: - NIL delimiters for LIST emailjs/emailjs-imap-client#27 and LSUB emailjs/emailjs-imap-client#29 (discovered while investigating bug 1091295 and bug 1084216)
asutherland
added a commit
to asutherland/gaia-email-libs-and-more
that referenced
this pull request
Nov 27, 2014
This is primarily a move to the upgrade startTLS functionality. This included a fix to the SMTP implementation where a server could avoid TLS-initiation by not implementing EHLO. (emailjs/emailjs-smtp-client#20). This goal was bug 1060558. An additional fix we had made locally but not upstreamed (but have now upstreamed) and that has improved test coverage on our end (see test_mine) is a problem relating to newlines. See emailjs/emailjs-imap-client#35. Other (new) fixes folded in here: - Namespace NIL delimiter: emailjs/emailjs-imap-client#36 - trailing whitespace in bodystructure list: emailjs/emailjs-imap-handler#8 Fixes we had made locally and upstreamed but not taken via the release process: - NIL delimiters for LIST emailjs/emailjs-imap-client#27 and LSUB emailjs/emailjs-imap-client#29 (discovered while investigating bug 1091295 and bug 1084216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops! I was hurrying a bit and although I dealt with LIST in #27 I completely forgot to check and handle the LSUB case in my haste. (We hadn't previously used LSUB ourselves.) Apologies; I'll try and make sure to run full local tests before putting up pull requests in the future. Things should get easier when we're 100% up-to-date with browserbox upstream in our rep.