Skip to content

feat(logger): add customError function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2018
Merged

feat(logger): add customError function #1

merged 2 commits into from
May 25, 2018

Conversation

Valetudox
Copy link
Contributor

@Valetudox Valetudox commented May 24, 2018 •
edited
Loading

I had copied the tests from a similar method I found a couple of exciting things:

  • Multiple expects per it block
  • Seven expects from eight are the same in three tests
  • Very hard to figure it out which tests belong to a specific method

Implementation:

  • Extra methods with prototype extension and Class usage a little bit strange for me

sonicoder86
sonicoder86 approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@sonicoder86 sonicoder86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
warnFromError becomes deprecated with this new function

@sonicoder86 sonicoder86 merged commit f56038b into master May 25, 2018
@emarsys-deployer
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SchroederSteffen SchroederSteffen deleted the custom-error branch May 9, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcdevil pcdevil Awaiting requested review from pcdevil

@tt1991 tt1991 Awaiting requested review from tt1991

1 more reviewer

@sonicoder86 sonicoder86 sonicoder86 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Valetudox @emarsys-deployer @sonicoder86