Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure gruntfile to issue minified versions only on deploy/dynamic dapp capabilities #82

Closed
VoR0220 opened this issue Sep 10, 2015 · 1 comment

Comments

@VoR0220
Copy link
Contributor

VoR0220 commented Sep 10, 2015

This is a simple thing to get done. Unfortunately, I am not big on .coffee scripts and have opted instead to convert them into .js scripts so if I make a PR, perhaps translation is necessary for a merge?

I think that when developing, a minified version is a handicap, not a benefit, as they are obviously impossible to read, so my suggestion would be to make the pre installed Gruntfile only deploy a minified version if the deploy command is actually called. For testing purposes, it should take the files as they are and push them into the generated dapp folder.

My second proposal is to automatically apply the express server with a view engine capable of dynamic dapps. This too is simple to do and I can get a PR request to you on that soon.

Any thoughts?

@iurimatias
Copy link
Collaborator

old ticket but still relevant. embark 2 does not minify by default, and it's possible now in 2.3.0 to minify and create maps using plugins

iurimatias pushed a commit that referenced this issue Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants