Provide cacheKey
to enable cache-busting based on runtime config
#93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So after #90 was merged ast-plugins could bust the cache based on directory changes, which is awesome and something addons like ember-cli-conditional-compile has needed for a while.
However like @rwjblue said in #90 it was made to work similarly to babel/broccoli-babel-transpiler#89, which also includes a
cacheKey
method which augments the cacheKeys based on runtime configurations rather than file-directory changes.It's a feature I would like to have so this is my attempt at implementing it for HTMLBars 🙏
I've been going through various PR's like #90, babel/broccoli-babel-transpiler#89, ember-cli/babel-plugin-feature-flags#12 and what documentation I could find about it to get a grip on what it should do.
So far I have tested it with ember-cli-conditional-compile by registering the ast-plugin with
cacheKey
method returning its featureFlags which are based on environment setup, and it's been working well so far.This is my first real contribution to Ember, so I might be out on deep waters, but feel free to modify or close the PR if I'm way off about this 😂