Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide cacheKey to enable cache-busting based on runtime config #93

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

jobackman
Copy link
Contributor

Hi,

So after #90 was merged ast-plugins could bust the cache based on directory changes, which is awesome and something addons like ember-cli-conditional-compile has needed for a while.

However like @rwjblue said in #90 it was made to work similarly to babel/broccoli-babel-transpiler#89, which also includes a cacheKey method which augments the cacheKeys based on runtime configurations rather than file-directory changes.

It's a feature I would like to have so this is my attempt at implementing it for HTMLBars 🙏

I've been going through various PR's like #90, babel/broccoli-babel-transpiler#89, ember-cli/babel-plugin-feature-flags#12 and what documentation I could find about it to get a grip on what it should do.

So far I have tested it with ember-cli-conditional-compile by registering the ast-plugin with cacheKey method returning its featureFlags which are based on environment setup, and it's been working well so far.

This is my first real contribution to Ember, so I might be out on deep waters, but feel free to modify or close the PR if I'm way off about this 😂

@reidab
Copy link

reidab commented Jan 31, 2017

Any movement here? We're using ember-cli-conditional-compile and keep hitting issues around this.

@minichate
Copy link

Anything I can do to help with this?

@stefanpenner stefanpenner merged commit 1145dca into ember-cli:master Apr 17, 2017
@stefanpenner
Copy link
Contributor

released as v1.3.0 🎉

@minichate
Copy link

Thanks!

@minichate
Copy link

@jobackman I'll work on applying this to https://github.com/minichate/ember-cli-conditional-compile right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants