Adding a default timeout for QUnit tests. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,7 @@ | |||
| QUnit.config.urlConfig.push({ id: 'nocontainer', label: 'Hide container'}); | |||
| QUnit.config.urlConfig.push({ id: 'nojshint', label: 'Disable JSHint'}); | |||
| QUnit.config.urlConfig.push({ id: 'doccontainer', label: 'Doc test pane'}); | |||
| QUnit.config.testTimeout = 300000 //Default Test Timeout 5 Minutes | |||
There was a problem hiding this comment.
Lets swap to 60000ms (60 seconds) as a default, folks can increase it from there if they need to.
|
👍 for this as a default, it is pretty easy for folks to change the number via: // tests/test-helper.js
QUnit.config.testTimeout = undefined; // or whatever |
rwjblue
added a commit
that referenced
this pull request
Apr 14, 2015
Adding a default timeout for QUnit tests.
|
I like the 60 second timeout a lot more. I just didn't want to step on toes =p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, we had a developer check in a test that hung our build all weekend.
I would like to propose putting in a default test timeout into this package.
I think that 5 minutes is a really long time for qunit tests, but I'm not sure what kind of long running tests people might have.
I'm open to suggestions regarding the duration of the default timeout.