Fix bower dependency path when in child directory #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
changed the title
I found this bug while investigating emberjs/data#4096 Basically, when you're in a child directory of your app, such as `your-app/app/`, the dependency checks for bower components fail because they cannot find the version. This is because the version checker is using `project.bowerDirectory` to build the path to the dependency. Since `project.bowerDirectory` defaults to the name "bower_components" and not the actual path, this doesn't work unless you're inside your app's root directory when the dependency check is run.
HeroicEric
force-pushed
the
bower-dep-from-nested-dir
branch
from
bd61178
to
75185d3
Compare
HeroicEric
changed the title
rwjblue
added a commit
that referenced
this pull request
Jan 21, 2016
Fix bower dependency path when in child directory
|
Thank you! |
|
Published as v1.1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug while investigating emberjs/data#4096
Basically, when you're in a child directory of your app, such as
your-app/app/, the dependency checks for bower components fail because they cannot find the version.This is because the version checker is using
project.bowerDirectoryto build the path to the dependency. Sinceproject.bowerDirectorydefaults to the name "bower_components" and not the actual path, this doesn't work unless you're inside your app's root directory when the dependency check is run.I'm not sure how to write a test that covers this but I promise it works😈