Refactor to Node 4 supported ES2015 syntax. #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
May 5, 2017
.travis.yml
Outdated
|
|
||
| before_script: | ||
| # ensure we are testing against latest versions of all deps when using Yarn | ||
| - yarn upgrade |
There was a problem hiding this comment.
I'd prefer to use --no-lockfile since we use that everywhere else too
.travis.yml
Outdated
|
|
||
| branches: | ||
| only: | ||
| - master |
There was a problem hiding this comment.
I can't have my own fork (transfered from rwblue to ember-cli) so I added this because I don't want to kick off two CI jobs for my PR branch pushes.
There was a problem hiding this comment.
I think the move has happened long enough ago for you to be able to fork again 🤷♂️
There was a problem hiding this comment.
I'd rather just not worry about it. I updated this to match what ember-cli itself does: https://github.com/ember-cli/ember-cli/blob/master/.travis.yml#L9-L15.
Also setup yarn caching.
These were from when ember-cli-version-checker *only* checked for ember-cli's own version number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classconst/letyarn.lock