fix: fallback to project if addon has no root

[buschtoens]

Fixes #70.

[ef4]

Thanks @buschtoens, I'm using this patch to workaround the bug for ember-auto-import's test suite (which is now a monorepo, so I can more easily test both babel 6 and babel 7 based apps).

[rwjblue]

I'd like to land this (or fix @ember-decorators/babel-transforms), would you mind adding a previously failing test?

[alexlafroscia]

Would it make more sense for the EmberAddon object for the dummy app to have a root property instead of working around that quirk here?

[buschtoens]

If the notion of root is applicable to an EmberAddon, this would also be a nice fix, I guess. However, that would require affected users to upgrade their host ember-cli version. So maybe we'd wanna do both?

[buschtoens]

@rwjblue I've added a test for the addon scenario:

falls back to the project root for instances of EmberAddon that do not have a root property

I wanted to add a real life workspaces scenario as well that explicitly checks that resolve.sync does not fall back to the caller file's physical location, but that is not possible with the current test harness, since the caller file is the test itself.

Let me know, if you want me to change anything.

[rwjblue]

but that is not possible with the current test harness, since the caller file is the test itself

I've just landed some new tests that could show how to do this...

[buschtoens]

@rwjblue Thanks for providing such a great basis and pushing for good tests! I've added a real life workspaces scenario.

Want me to change something?

[rwjblue]

Thank you @buschtoens!

[rwjblue]

ember-cli-version-checker 3.0.1 published 🎉