Perf fix: cache the resolutions identically to how require does. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current CI failure is due to eslint failures. |
davecombs
suggested changes
Feb 26, 2019
|
Alright back from lunch, going to tidy this up. |
stefanpenner
force-pushed
the
perf-poc
branch
from
427a718
to
9c5bb4f
Compare
stefanpenner
changed the title
|
Alright, created resolve-package-path which harvests @davecombs's work from hash-for-dep into a reusable library. We can then have this and that library both share the same code/cache. |
Turns out this is extremely expensive, and apps with many apps/engines/in-repo addons spend up to minutes here.
stefanpenner
force-pushed
the
perf-poc
branch
from
9c5bb4f
to
ff0909d
Compare
rwjblue
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this is extremely expensive, and apps with many
apps/engines/in-repo addons spend up to minutes here.
We should discuss better/improved/ideal solutions, i don't like this approach really, and we keep playing wack-a-mole with similar solutions anytime we use require.resolve....
But this is worth a discussion, as this approach really does save ALOT (for very large apps, minutes) of startup time.