Fix issue with addon directory not being linted #5592
Conversation
| return ember(['test']); | ||
| }) | ||
| .then(function(result) { | ||
| expect(result.exitCode).to.not.eql(0); |
There was a problem hiding this comment.
Can we also check the results.output to confirm that the right test failed? Something like (stolen from another test I recently added):
var output = result.output.join(EOL);
expect(output).to.match(/TemplateLint:/, 'ran template linter');
There was a problem hiding this comment.
I tried to do this; results.output was undefined, and results.outputStream didn't have anything in it that could be used to verify which test exactly failed.
|
@alexlafroscia - Looks really good, thanks for tackling. I left two comments (one is a bug and the other is more of a nit-pick) to address, then we can land this... |
alexlafroscia
force-pushed
the
fix-addon-linting
branch
from
25cde2b
to
6f2a45d
Compare
|
Alright, so I pushed an update to the previous commit that updates the acceptance-style test to use One thing that I was unable to do was verify the output text the way you mentioned. Inside the |
Fix issue with addon directory not being linted
|
Thank you @alexlafroscia! |
|
@rwjblue thanks for your help and guidance on this! I'm excited to finally be contributing to the CLI itself 😄 |
[BUGFIX beta] Fix addon linting regression. This was originally fixed in #5592, but likely regressed during the "great core-object migration of 2016" (:smiling_imp:). #5498 contains a good description of why using `eachAddonInvoke` doesn't work and shows the reasoning behind `_eachProjectAddonInvoke`.
Closes #5498