-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX beta] allow more then 10 exit handlers #5987
Conversation
LGTM 👍 |
do we want this on side note: as discussed in #5955 we should think about targeting these PRs directly at the |
i suspect release. |
I don't feel strongly, but this doesn't seem like a critical bugfix. Seems safe for both beta and release, but it also isn't a giant deal and I think our default answer should be "beta" for all but critical fixes... |
Doesn't seem critical to me–everything still works, you just get these messages. I'd aim for beta on principle. |
Cherry picked this to |
We upgraded to ember-cli 2.4.3, and all associated dependencies with the exception of ember data, and I did not hit this warning. Later we upgraded ember data to 2.3 (can't move past that version at this point) and this warning suddenly appeared. Is there any way we can change the maxListeners? |
@lmcardle this is slated for 2.7 release, the diff shows how one could manually add it to there project: https://github.com/ember-cli/ember-cli/pull/5987/files#diff-3386b9e4d97ad97b803f4678beb66c5aR23 just put that line in your ember-cli-build.js file |
@stefanpenner you sir are awesome. That appears to work great! |
@lmcardle nice, I'm glad to hear it worked for you. I don't think nodes default value here needs to change eventually, or maybe the approach at-together, but this will buy us some time. |
Nomination for understatement of the year. |
For those who can't update to ember 2.7 right now, it's possible to fix this warning message by adding this line to the end of the "ember-cli-build.js" file:
|
@hugoruscitti thanks or sharing the tip, remember though the build tooling can be upgraded independently. Although it may require a more granular update. |
We can decide on a more appropriate number (if others feel that is required).
Resolves emberjs/ember-cli-babel#76