Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] allow more then 10 exit handlers #5987

Merged
merged 1 commit into from
Jun 16, 2016

Conversation

stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner commented Jun 15, 2016

We can decide on a more appropriate number (if others feel that is required).

Resolves emberjs/ember-cli-babel#76

@Turbo87
Copy link
Member

Turbo87 commented Jun 15, 2016

LGTM 👍

@Turbo87
Copy link
Member

Turbo87 commented Jun 15, 2016

do we want this on release though or should we put this through a beta cycle?

side note: as discussed in #5955 we should think about targeting these PRs directly at the release or beta branches to reduce the amount of duplicated commits and have TravisCI/AppVeyor test for these branches directly.

@Turbo87 Turbo87 added the bug label Jun 15, 2016
@stefanpenner
Copy link
Contributor Author

do we want this on release though or should we put this through a beta cycle?

i suspect release.

@rwjblue
Copy link
Member

rwjblue commented Jun 15, 2016

I don't feel strongly, but this doesn't seem like a critical bugfix. Seems safe for both beta and release, but it also isn't a giant deal and I think our default answer should be "beta" for all but critical fixes...

@nathanhammond
Copy link
Contributor

Doesn't seem critical to me–everything still works, you just get these messages. I'd aim for beta on principle.

@Turbo87 Turbo87 merged commit 3026677 into master Jun 16, 2016
@Turbo87 Turbo87 deleted the bump-process-max-listeners branch June 16, 2016 09:22
@Turbo87 Turbo87 added this to the v2.7.0 milestone Jun 16, 2016
@Turbo87
Copy link
Member

Turbo87 commented Jun 16, 2016

Cherry picked this to beta. I agree with @rwjblue that this isn't critical enough for a stable release.

@Turbo87 Turbo87 changed the title [BUGFIX release] allow more then 10 exit handlers [BUGFIX beta] allow more then 10 exit handlers Jun 20, 2016
@lmcardle
Copy link

We upgraded to ember-cli 2.4.3, and all associated dependencies with the exception of ember data, and I did not hit this warning. Later we upgraded ember data to 2.3 (can't move past that version at this point) and this warning suddenly appeared. Is there any way we can change the maxListeners?

@stefanpenner
Copy link
Contributor Author

@lmcardle this is slated for 2.7 release, the diff shows how one could manually add it to there project: https://github.com/ember-cli/ember-cli/pull/5987/files#diff-3386b9e4d97ad97b803f4678beb66c5aR23 just put that line in your ember-cli-build.js file

@lmcardle
Copy link

@stefanpenner you sir are awesome. That appears to work great!

@stefanpenner
Copy link
Contributor Author

@lmcardle nice, I'm glad to hear it worked for you. I don't think nodes default value here needs to change eventually, or maybe the approach at-together, but this will buy us some time.

@nathanhammond
Copy link
Contributor

this will buy us some time.

Nomination for understatement of the year.

@hugoruscitti
Copy link

For those who can't update to ember 2.7 right now, it's possible to fix this warning message by adding this line to the end of the "ember-cli-build.js" file:

process.setMaxListeners(1000);

@stefanpenner
Copy link
Contributor Author

@hugoruscitti thanks or sharing the tip, remember though the build tooling can be upgraded independently. Although it may require a more granular update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants