Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding back feature to customization of serveURL #8069

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Adding back feature to customization of serveURL #8069

merged 2 commits into from
Sep 26, 2018

Conversation

SparshithNR
Copy link
Contributor

Adding back the feature from #7936 which got removed by ccfa432

rwjblue
rwjblue requested changes Sep 25, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to help ensure this doesn't regress again?

@rwjblue rwjblue changed the base branch from master to release September 26, 2018 02:13
@rwjblue
Copy link
Member

rwjblue commented Sep 26, 2018

Updated to target release and rebased.

@rwjblue rwjblue merged commit 0eafc19 into ember-cli:release Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SparshithNR @rwjblue