Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-qunit #639

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Upgrade ember-qunit #639

merged 1 commit into from
Aug 4, 2021

Conversation

nlfurniss
Copy link
Collaborator

Need to upgrade in order for ember-canary tests to not fail right out of the gate

@nlfurniss
Copy link
Collaborator Author

Dunno why we're linting node_modules, but I'm going to land this anyway since we're moving to GH CI

$ eslint . --cache
/home/travis/build/ember-cli/ember-fetch/node_modules/.bin/sha.js
   3:18  error  'require' is not defined      no-undef
   4:12  error  'process' is not defined      no-undef
  15:9   error  'process' is not defined      no-undef
  16:14  error  Unexpected console statement  no-console
  19:5   error  Unexpected console statement  no-console
  24:3   error  Unexpected console statement  no-console
  25:3   error  Unexpected console statement  no-console
  26:3   error  Unexpected console statement  no-console
  29:6   error  'process' is not defined      no-undef
  30:17  error  'process' is not defined      no-undef
  37:21  error  'require' is not defined      no-undef
✖ 11 problems (11 errors, 0 warnings)

@nlfurniss nlfurniss merged commit 14f62e6 into master Aug 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-ember-qunit branch August 4, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant