Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --config-path to be specified to ember-try commands. #50

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Feb 1, 2016

This allows groups of configurations to be used with various commands.

For example, it would be nice in ember-test-helpers to group "legacy" Ember versions together and run them as a single matrix build with:

ember try:testall --config-path=config/legacy-scenarios.js

Then we could run current scenarios in another matrix build like:

ember try:testall --config-path=config/current-scenarios.js

This allows groups of configurations to be used with various commands.

For example, it would be nice in ember-test-helpers to group "legacy"
Ember versions together and run them as a single matrix build with:

```
ember try:testall --config-path=config/legacy-scenarios.js
```

Then we could run current scenarios in another matrix build like:

```
ember try:testall --config-path=config/current-scenarios.js
```
@rwjblue
Copy link
Member Author

rwjblue commented Feb 1, 2016

@kategengler - Would love your thoughts here...

@kategengler
Copy link
Member

Sounds (and looks) good to me, thanks!

kategengler added a commit that referenced this pull request Feb 1, 2016
Allow --config-path to be specified to ember-try commands.
@kategengler kategengler merged commit b2d8f99 into ember-cli:master Feb 1, 2016
@rwjblue rwjblue deleted the allow-config-path-to-be-specified branch February 1, 2016 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants