Handle decorators

[ssutar]

This PR handles different decorators mentioned in #1

[pzuraq]

Overall looking good, some minor comments but I think the structure is looking good. Generally bucketing things into parse and transform helpers seems to be a solid pattern, and config of whether to use decorators or not is 👍

[pzuraq]

Is there an upstream PR here? Ideally we should get that merged and published before we merge this

[ssutar]

Yes, there is PR rwjblue/codemod-cli#41 Not sure if it will be merged. I'll sync up with @rwjblue and merge it

[pzuraq]

This should be transformed to the following:

class Foo extends EmberObject.extend(MyMixin) {
  biz = 'div';
}

[ssutar]

I was thinking of adding mixin support in different PR

[pzuraq]

It looks like you added mixin support, so this test case can be removed/updated?

[ssutar]

Mixin support is added with config option --mixins=true with codemod command line. Please see the mixins.options.json. So we need to keep the mixin test case

[pzuraq]

This should transform to:

@layout('div')
class Foo extends EmberObject {}

[pzuraq]

We may want to come back to observers/event listeners. The trickiness is in subclasses, we must apply the opposite if the field is overriden:

const Foo = EmberObject.extend({
  fooObserver: observer('foo', function() {})
});

const Bar = Foo.extend({
  fooObserver: null, // unsets the observer
});

class Foo extends EmberObject {
  @observes('foo') fooObserver() {}
}

class Bar extends Foo {
  @unobserves('foo') fooObserver = null;
}

This will mean we have to add a second pass to the codemod, since we can't know what the subclass/superclass is until we've completed the first pass.

[ssutar]

Thanks for the detail, I'll create a new issue so that we can track this separately

[ssutar]

Added #7

[pzuraq]

Looks good, one minor comment about a test case but I think once that's resolved this is good to merge 👍

[pzuraq]

It looks like you added mixin support, so this test case can be removed/updated?

[pzuraq]

I think this may need to change to alias('firstName', 'lastName').readOnly(), but since ember-decorators doesn't have this API yet we merge this for now and update it later on once that API is finalized

[ssutar]

Mixin support is added with config option --mixins=true with codemod command line. Please see the mixins.options.json. So we need to keep the mixin test case

[pzuraq]

Sounds good, thanks again @ssutar!