Skip to content

Update to ember-router-scroll v4 #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2021
Merged

Update to ember-router-scroll v4 #767

merged 2 commits into from
Mar 5, 2021

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Mar 5, 2021

Closes #766

@Windvis
Copy link
Contributor Author

Windvis commented Mar 5, 2021

Hmm, not sure what's going on in the failing test case.

@RobbieTheWagner
Copy link
Member

@Windvis looks like ember-maybe-import-regenerator is missing from this addons devDeps. I think we need to change it here https://github.com/ember-learn/ember-cli-addon-docs/blob/master/test-apps/new-addon/package.json#L41

It should be ember-maybe-import-regenerator-for-testing

@Windvis
Copy link
Contributor Author

Windvis commented Mar 5, 2021

@Windvis looks like ember-maybe-import-regenerator is missing from this addons devDeps. I think we need to change it here https://github.com/ember-learn/ember-cli-addon-docs/blob/master/test-apps/new-addon/package.json#L41

It should be ember-maybe-import-regenerator-for-testing

Seems like that indeed was the issue. Thanks!

@RobbieTheWagner RobbieTheWagner merged commit 41d6152 into ember-learn:master Mar 5, 2021
@RobbieTheWagner
Copy link
Member

Thanks for the PR @Windvis! 🎉

@Windvis Windvis deleted the ember-router-scroll-v4-update branch May 12, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setupRouter deprecation warning
2 participants
@Windvis @RobbieTheWagner