Skip to content

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented Feb 19, 2020

Followed: #490

  • Assumed date was today, Feb 18
  • nextDate = Mar 25, 6wk from initialReleaseDate
  • initialReleaseDate = Feb 12, date of blog post
  • For version #s, went to GitHub repo links

Resolves: #568

Let me know if needs edits or feel free to commit directly to the branch!

@amyrlam amyrlam requested a review from locks February 19, 2020 06:27
@github-actions
Copy link

Files that stayed the same size 🤷‍:

File raw gzip
ember-website.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
vendor.js 0 B +1 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

locks
locks previously approved these changes Feb 19, 2020
Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help!
Left some corrections, the way this works is a bit strange. The release dates for the libraries is the date it was published to npm, even though our "ember release" is the blog post announcement.

Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
amyrlam and others added 3 commits February 19, 2020 09:02
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
@github-actions
Copy link

Files that stayed the same size 🤷‍:

File raw gzip
ember-website.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
vendor.js 0 B -1 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
vendor.js -791 B -321 B

Files that stayed the same size 🤷‍:

File raw gzip
ember-website.js 0 B +1 B
ember-website-fastboot.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Files that stayed the same size 🤷‍:

File raw gzip
ember-website.js 0 B +1 B
ember-website-fastboot.js 0 B 0 B
vendor.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
vendor.js -791 B -321 B

Files that stayed the same size 🤷‍:

File raw gzip
ember-website.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
@amyrlam
Copy link
Member Author

amyrlam commented Feb 19, 2020

@locks I think it makes sense... ready for re-review

I can do the next one, started following ember-learn/ember-blog#536

@github-actions
Copy link

Files that got Smaller 🎉:

File raw gzip
vendor.js -791 B -321 B

Files that stayed the same size 🤷‍:

File raw gzip
ember-website.js 0 B 0 B
ember-website-fastboot.js 0 B 0 B
ember-website.css 0 B 0 B
vendor.css 0 B 0 B

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated, thank you!

@locks locks merged commit 5b239fa into master Feb 20, 2020
@locks locks deleted the amy/3-16-update branch February 20, 2020 01:33
amyrlam added a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: https://emberjs.com/releases/ is not up to date
2 participants