Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to <AngleBracket /> built-in components on Octane branch (input, link-to, etc) #692

Closed
16 tasks done
chancancode opened this issue Mar 28, 2019 · 11 comments
Closed
16 tasks done
Labels
help wanted Extra attention is needed Octane

Comments

@chancancode
Copy link
Contributor

chancancode commented Mar 28, 2019

It's time to switch the Octane guides to use built-in components!

  • {{link-to}} -> <LinkTo />
  • {{input}} -> <Input />
  • {{textarea}} -> <Textarea />

This should mostly just be a syntactic change, but we could also take the opportunity to adjust the flow, remove legacy concepts, etc. For example, since angle bracket invocation takes HTML attributes, we can update the examples to pass them directly (i.e. class= instead of @class=).

To help out, please leave a comment to "claim" the item (🔒 below) so others know not to duplicate the effort! It's fine to claim the item before you have a PR ready (but please release it if it turns out you didn't have the time to do it). Branch from the octane branch of the Guides and open your PR to be merged back into octane. Thank you!

Some resources:

Guides that need to be updated:

@chancancode chancancode changed the title Switch to <BuiltInComponents /> on Octane branch Switch to <AngleBracket /> built-in components on Octane branch Mar 28, 2019
ddoria921 added a commit to ddoria921/guides-source that referenced this issue Mar 28, 2019
@jenweber jenweber changed the title Switch to <AngleBracket /> built-in components on Octane branch Switch to <AngleBracket /> built-in components on Octane branch (input, link-to, etc) Mar 28, 2019
@jenweber jenweber added the help wanted Extra attention is needed label Mar 28, 2019
@alexBaizeau
Copy link
Contributor

I'm claiming components/actions-and-events.md

@alexBaizeau
Copy link
Contributor

I'm claiming routing/query-params.md

@Charizard
Copy link
Contributor

Would like to claim routing/specifying-a-routes-model.md

@Charizard
Copy link
Contributor

Would like to claim testing/testing-components.md

@zachgarwood
Copy link
Contributor

zachgarwood commented Mar 29, 2019

It appears that tutorial/autocomplete-component.md has already been angle-bracket-ized. Nevermind.

I claim tutorial/autocomplete-component.md.

@mdbiscan
Copy link
Contributor

mdbiscan commented Mar 29, 2019

I'll claim the next one, tutorial/model-hook.md

@ClaytonTurner
Copy link
Contributor

I'll claim the one after that: tutorial/routes-and-templates.md

@mdbiscan
Copy link
Contributor

I'll claim tutorial/simple-component.md.

@dknutsen
Copy link
Contributor

I'll claim tutorial/subroutes.md

@mdbiscan
Copy link
Contributor

mdbiscan commented Mar 29, 2019

Happy to claim upgrading/editions.md

@jenweber
Copy link
Contributor

Thanks everyone for your help with these changes! And thank you @chancancode for coordinating.

We finished the last file in #753 plus some prose in #696

lenoraporter pushed a commit to lenoraporter/guides-source that referenced this issue Jul 19, 2020
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this issue Jul 19, 2020
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this issue Jul 19, 2020
lenoraporter pushed a commit to lenoraporter/guides-source that referenced this issue Jul 19, 2020
Also, I reformatted the paragraphs in question to be <80 characters
long.

(ember-learn#692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Octane
Projects
None yet
Development

No branches or pull requests

9 participants