-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to <AngleBracket /> built-in components on Octane branch (input, link-to, etc) #692
Comments
I'm claiming |
I'm claiming |
Would like to claim |
Would like to claim |
I claim |
I'll claim the next one, |
I'll claim the one after that: |
I'll claim tutorial/simple-component.md. |
I'll claim tutorial/subroutes.md |
Happy to claim |
Thanks everyone for your help with these changes! And thank you @chancancode for coordinating. |
Also, I reformatted the paragraphs in question to be <80 characters long. (ember-learn#692)
It's time to switch the Octane guides to use built-in components!
{{link-to}}
-><LinkTo />
{{input}}
-><Input />
{{textarea}}
-><Textarea />
This should mostly just be a syntactic change, but we could also take the opportunity to adjust the flow, remove legacy concepts, etc. For example, since angle bracket invocation takes HTML attributes, we can update the examples to pass them directly (i.e.
class=
instead of@class=
).To help out, please leave a comment to "claim" the item (🔒 below) so others know not to duplicate the effort! It's fine to claim the item before you have a PR ready (but please release it if it turns out you didn't have the time to do it). Branch from the
octane
branch of the Guides and open your PR to be merged back intooctane
. Thank you!Some resources:
Guides that need to be updated:
components/actions-and-events.md
(:lock: @alexBaizeauUpdate docs for the built-in components for components/actions-and-events.md #697)models/index.md
(🔒 @chancancodeAngle bracket <BuiltIn /> components #681)routing/defining-your-routes.md
(🔒 @chancancodeAngle bracket <BuiltIn /> components #681Follow-up to #681 #693)routing/preventing-and-retrying-transitions.md
(🔒 @chancancodeAngle bracket <BuiltIn /> components #681)routing/query-params.md
(:lock: @alexBaizeauUpdate docs for the built-in components in)routing/query-params.md
#698routing/specifying-a-routes-model.md
(:lock: @CharizardUpdate docs for the built-in components for routing/specifying-a-routes-model.md #699)templates/binding-element-attributes.md
(🔒 @chancancodeAngle bracket <BuiltIn /> components #681)templates/input-helper.md
(:lock: @ddoria921 Update input helpers page #696)templates/links.md
(🔒 @chancancodeAngle bracket <BuiltIn /> components #681)testing/testing-components.md
(:lock: @CharizardUpdate docs for the built-in components for testing components page #700)tutorial/auto-complete-component.md
(:lock: @zachgarwoodAngle-bracket-ize tutorial/autocomplete-component.md #702)tutorial/model-hook.md
(:lock: @mdbiscanUpdate docs for the built-in components for model-hook page #704)tutorial/routes-and-templates.md
(:lock: @ClaytonTurnerUpdate docs for the built-in components for tutorial/routes-and-templ… #705)tutorial/simple-component.md
(:lock: @mdbiscanUpdate docs for the built-in components for simple-component page #706)tutorial/subroutes.md
(:lock: @dknutsenUpdate subroute guides to use angle bracket built-ins #707)upgrading/editions.md
(:lock: @mdbiscanUpdating upgrading editions.md #709)The text was updated successfully, but these errors were encountered: