Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot volume beta API #159

Closed
awels opened this issue Mar 12, 2020 · 4 comments · Fixed by #162
Closed

Snapshot volume beta API #159

awels opened this issue Mar 12, 2020 · 4 comments · Fixed by #162
Labels
enhancement New feature or request examples Related to the examples

Comments

@awels
Copy link

awels commented Mar 12, 2020

Currently ember installs the alpha volume snapshot api, which has been deprecated in kubernetes 1.17 and no longer supported in openshift. Please install the betav1 api when the controller is started.

@Akrog
Copy link
Member

Akrog commented Mar 12, 2020

Are you referring to the VolumeSnapshotClass in the 1.16 Kubernetes example?

OpenShift 4.3 supports snapshot.storage.k8s.io/v1alpha1, it is 4.4 that doesn't support it.

Yes we need to update the examples to support K8s versions higher than 1.16.

@Akrog Akrog added the enhancement New feature or request label Mar 12, 2020
@Akrog Akrog added the examples Related to the examples label Mar 12, 2020
@awels
Copy link
Author

awels commented Mar 12, 2020

Yes, but it appears the controller actually installs some CRDs (it has the cluster role to do so, which is probably not something we want the controller to do).

$ kubectl get crd
NAME                                             CREATED AT
volumesnapshotclasses.snapshot.storage.k8s.io    2020-03-11T18:26:37Z <-- is from example
volumesnapshotcontents.snapshot.storage.k8s.io   2020-03-11T18:26:37Z <-- controller?
volumesnapshots.snapshot.storage.k8s.io          2020-03-11T18:26:37Z <-- controller?

I am not entirely sure what installs the other two crds

@Akrog
Copy link
Member

Akrog commented Mar 12, 2020

The other 2 are most likely created by the snapshotter sidecar because the wrong sidecar is being used.
Kubernetes v1.17 needs a different snapshotter sidecar.
For K8s v1.16 or is v1.y.z of the sidecar, and K8s is v2.y.z (reference)

@awels
Copy link
Author

awels commented Mar 12, 2020

Gotcha, so I just need to update the yaml to use the correct side car. I grepped the project and I couldn't find anything creating them. But the side car makes sense. So yeah just need to update the examples for 1.17 to use the new api and side car.

Akrog added a commit to Akrog/ember-csi that referenced this issue Apr 7, 2020
This patch adds the example for Kubernetes 1.17

Unlike READMEs from previous releases this one has been summarized.

Fix embercsi#159
Akrog added a commit to Akrog/ember-csi that referenced this issue Apr 8, 2020
This patch adds the example for Kubernetes 1.17

Unlike READMEs from previous releases this one has been summarized.

Fix embercsi#159
Akrog added a commit to Akrog/ember-csi that referenced this issue Apr 8, 2020
This patch adds the example for Kubernetes 1.17

Unlike READMEs from previous releases this one has been summarized.

Fix embercsi#159
trgill pushed a commit to trgill/ember-csi that referenced this issue Apr 21, 2020
This patch adds the example for Kubernetes 1.17

Unlike READMEs from previous releases this one has been summarized.

Fix embercsi#159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request examples Related to the examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants