-
-
Notifications
You must be signed in to change notification settings - Fork 47
add notes for learning 17th June #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# 2024-06-17 | ||
|
||
Note Taker: Chris Manson | ||
Time Keeper: Anne-Greeth Schot-van Herwijnen | ||
|
||
## Attendees | ||
|
||
Add yourself to the list if you attend and check the box! | ||
|
||
### Core Team | ||
|
||
- [x] Chris Manson (CM) | ||
- [x] Jared Galanis (JG) | ||
- [ ] Jen Weber (JW) | ||
- [ ] Ricardo Mendes (RM) | ||
- [ ] Robert Wagner (RW) | ||
- [x] Anne-Greeth Schot-van Herwijnen (AG) | ||
- [x] Ignace Maes (IM) | ||
|
||
## Topics | ||
|
||
### Feature Flag / Toggle <@jaredgalanis> | ||
|
||
- https://github.com/ember-learn/guidemaker-ember-template/pull/191 | ||
|
||
- JG: discussion about feature flags | ||
- IM: basic implementaion is imporant | ||
- then we can start using it for other things like template tags | ||
- JS vs TS is another discussion | ||
- should we have switches per code block or globally | ||
- CM: I think we talked about needing surrounding blurbs | ||
- that way we shouldn't be | ||
- IM: we need to unblock polaris docs, we can get people to start contributing | ||
- CM: assuming the tech part is done, how do we deal with multiple toggles at the same time? polaris and typescript | ||
- do we need 4 versions of the docs? | ||
- CM: we need to be clear about the point of the feature flag | ||
- it is intended to be a mechanism to preview the new guides | ||
- (discussion about the feature flag) | ||
- (description of CM's idea of how the toggle will exactly work) | ||
- Action Item: CM to write down the exact plan so get everyone in the core teams can agree on the plan | ||
- (discussion about sub-flags) | ||
|
||
### Deprecations PR from Katie/Nullvox <@jaredgalanis> | ||
|
||
- https://github.com/ember-learn/deprecation-app/pull/1383 | ||
- CM: I don't think this is highest priority, I don't think we should complicate the data structure of the deprecations | ||
- (general discussion) | ||
- (general agreement that we don't need to merge the PR to get https://github.com/ember-learn/deprecation-app/pull/1381 merged) | ||
- JG: devil's advocate - we have been slow on making changes to the website so delaying merging the deprecation PR because of a new layout | ||
- CM: I'm not saying to not merge the deprecation PR, I think it's fine | ||
- (discussion about performance of the app) | ||
- AG will respond to the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.